-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Walk Listeners not working for 2019-09 meta schema #441
Comments
Validation itself is also being impacted. Loading up the 2019 meta schema spec and using it to validate the following payload returns no error messages:
The first property should return a validation error and using the exact same logic with the same schema but draft-07 will correctly return 2 validation errors. |
@dustinhiatt-wf I am guessing that some of the 2019 new validators don't have the walking method implemented. Do you know the root cause? |
@stevehu stepping through the code, the vocabularies aren't being pulled in before the validators are examining their "sections" to determine what schemas exist to validate. If I take the schema I posted earlier and examine this line: The schemas map has all the entries you'd expect. The 2019-09 version only includes the two properties in the base 2019-09 metaschema. Essentially, the validation logic is running while ignoring the In that context that this is running in, the read method won't see any properties from the vocabularies imported by |
@dustinhiatt-wf As far as my understanding we currently don't have the logic at place to pull the vocabularies on the fly. One approach I follow is to download all the vocabularies and assemble/collate the metaschema locally and then validate the schema against it. |
@dustinhiatt-wf The other member @ericbroda raised the same issue for the meta schema loading for the 2019-09 and I have created a test case in a separate branch to reproduce it. |
If I take the following simple schema definition:
And I attempt to load up the 2019 meta schema:
And I construct a factory as follows:
Where
jsonSchemaWalkListener
simply gathers up all properties usinggetAt
, notice that the walker is not called on all properties of the schema being validator. I do not see this behavior with the previous drafts. I am curious if this has to do with vocabularies.The text was updated successfully, but these errors were encountered: