Fixes #377: Non-devices do not save coordinates #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to save coordinates not only for devices but also for power feeds, power panels and circuits. In order to achieve this I had to add new models, because the recent coordinate model is only sufficient for devices (caused by foreign keys). Therefore, I needed to add a lot of boilerplate code. In fact, the change is not very big in terms of visible changes, but the boilerplate code leads to many code changes.
Known issue: The coordinate_groups template renders the coordinates_table, which contains device coordinates only. The NetBox framework doesn't support Unions and I found it not worth it to code around that problem, since it's just a nice-to-have table on this view. The alternative would be to simply not display the table at all.