Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved filter doesn't reload show cables #236

Closed
fafavorit opened this issue Jan 5, 2023 · 3 comments · Fixed by #475
Closed

Saved filter doesn't reload show cables #236

fafavorit opened this issue Jan 5, 2023 · 3 comments · Fixed by #475
Assignees
@dreng
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@fafavorit
Copy link

NetBox version

v3.4.2

Topology Views version

v3.2.0

Steps to Reproduce

  1. Create topology with enabled Show Cables
  2. Save filter
  3. Reload filter

Expected Behavior

I would expect to see connected devices as I had before saving filter.

Observed Behavior

Devices are displayed without connection cables. In saved filter definition is "show_cables": [ "on"]
@fafavorit fafavorit added the type: bug A confirmed report of unexpected behavior in the application label Jan 5, 2023
@dreng dreng added the status: accepted This issue has been accepted for implementation label Jan 6, 2023
@dreng
Copy link
Collaborator

dreng commented Jan 6, 2023

We have to check if this is an upstream bug with custom filter forms. Thanks for reporting!

@dreng dreng added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Jan 6, 2023
@dreng
Copy link
Collaborator

dreng commented Jan 7, 2023

I've had a sneak peek into the problem and I wonder if it's possible at all to integrate the checkboxes into the filterset without having a model for it. @mattieserver Can you answer that question?

In this case it is a somewhat bigger task and probably related to #78 .

@dreng dreng removed the status: accepted This issue has been accepted for implementation label Mar 19, 2023
@dreng dreng added the status: accepted This issue has been accepted for implementation label Jun 26, 2023
@dreng dreng mentioned this issue Jul 17, 2023
Closed
@dreng
Copy link
Collaborator

dreng commented Jul 18, 2023

Just for the record: I started a discussion at netbox-community/netbox#12397 regarding this issue but unfortunately I got no answer.

@dreng dreng self-assigned this Mar 30, 2024
@dreng dreng removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Mar 30, 2024
@dreng dreng mentioned this issue Mar 30, 2024
Merged
dreng added a commit that referenced this issue Mar 30, 2024
@dreng
Fixes #236: Saved filter doesn't reload show cables (#475)
c00b8c2 
* fix restore saved filter options

* fix restore saved filter group options

* fix htmx export to xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreng dreng

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #236: Saved filter doesn't reload show cables dreng/netbox-topology-views
2 participants
@dreng @fafavorit