Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework does not build with rust 1.61 #9

Closed
sylvainpelissier opened this issue Jun 12, 2022 · 3 comments
Closed

Framework does not build with rust 1.61 #9

sylvainpelissier opened this issue Jun 12, 2022 · 3 comments

Comments

@sylvainpelissier
Copy link

sylvainpelissier commented Jun 12, 2022

To reproduce:

$ rustup default 1.61 
$ cargo build                                                                                                                             ✔ 
   Compiling libsecp256k1 v0.5.0
   ...
   Compiling poc-framework v0.1.6 (/home/sylvain/software/solana-poc-framework)
error: expected None-delimited group
   --> src/lib.rs:741:21
    |
741 |                     solana_bpf_loader_upgradeable_program!(),
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in the macro `solana_bpf_loader_upgradeable_program` (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected None-delimited group
   --> src/lib.rs:742:21
    |
742 |                     solana_bpf_loader_program!(),
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in the macro `solana_bpf_loader_program` (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected None-delimited group
   --> src/lib.rs:743:21
    |
743 |                     solana_bpf_loader_deprecated_program!(),
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in the macro `solana_bpf_loader_deprecated_program` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `poc-framework` due to 3 previous errors

It seems to be related to rust-lang/rust#92472. It is solved by switching to rust 1.60:

$ rustup default 1.60
@tlambertz
Copy link

This is caused by (old) Solana upstream not building with 1.60 anymore.

I think their fix is in solana-labs/solana#24390

We'll have to update the core solana dependency of the poc-framework, but that'll take some work as we interact with internals that have changed now.

The easiest fix for now is to use an older compiler.

@riptl
Copy link
Contributor

riptl commented Jul 13, 2022

Fixed in #13

@riptl
Copy link
Contributor

riptl commented Aug 4, 2022

This can be closed @CherryWorm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants