Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_context: add GITHUB_RUN_ATTEMPT #2458

Merged
merged 5 commits into from
Sep 19, 2024
Merged

run_context: add GITHUB_RUN_ATTEMPT #2458

merged 5 commits into from
Sep 19, 2024

Conversation

catthehacker
Copy link
Member

Fixes #2451
Fixes #1615

@catthehacker catthehacker requested a review from a team as a code owner September 13, 2024 05:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 3 0 0.02s
✅ REPOSITORY gitleaks yes no 2.31s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 7.58s
✅ REPOSITORY secretlint yes no 1.0s
✅ REPOSITORY trivy-sbom yes no 0.47s
✅ REPOSITORY trufflehog yes no 4.0s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 13, 2024

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Sep 13, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 13, 2024

@catthehacker this pull request has failed checks 🛠

@ChristopherHX ChristopherHX self-assigned this Sep 19, 2024
ChristopherHX
ChristopherHX approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TestSetupEnv test should now pass, let's see if mergify let it pass

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.73%. Comparing base (5a80a04) to head (836305d).
Report is 112 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #2458       +/-   ##
===========================================
+ Coverage   61.56%   76.73%   +15.17%     
===========================================
  Files          53       62        +9     
  Lines        9002     8190      -812     
===========================================
+ Hits         5542     6285      +743     
+ Misses       3020     1342     -1678     
- Partials      440      563      +123

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the needs-work Extra attention is needed label Sep 19, 2024
@mergify mergify bot merged commit a34d9c6 into master Sep 19, 2024
12 checks passed
@mergify mergify bot deleted the fix/github-run-attempt branch September 19, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherHX ChristopherHX ChristopherHX approved these changes

Assignees

@ChristopherHX ChristopherHX

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GITHUB_RUN_ATTEMPT isn't set to 1 by default Add support for variable GITHUB_RUN_ATTEMPT
2 participants
@catthehacker @ChristopherHX