fix: improve err message #236
Conversation
| #[error("{kind}")] | ||
| Custom { | ||
| kind: ErrorKind, | ||
| #[source] | ||
| error: Box<dyn std::error::Error + Send + Sync>, | ||
| }, | ||
| #[error("{message}: {error}")] | ||
| #[error("{message}")] |
There was a problem hiding this comment.
Curious in these why for Custom the error is not included in this message (does source automatically include it?), and for Full, why the error kind is ignored
There was a problem hiding this comment.
yup, #[source] creates a chain of error message when you go to display it. For full, didn't see a need to include it since the error message should for the most part tell you what kind of class of errors it it. Normally I don't think kind is that useful in error messages unless there's no other context to the error
|
hmm, looks like 4.1.1 breaks |
Prob worth opening an issue for that. The error message was in the output, but that was very cryptic to read |
based on #232
Adds in the sandbox error improvement