Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on cluster/celltype filtering #106

Open
LinearParadox opened this issue Jul 28, 2024 · 1 comment
Open

Thoughts on cluster/celltype filtering #106

LinearParadox opened this issue Jul 28, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@LinearParadox
Copy link
Contributor

Hi all,

Loving the tool and have been playing around with it. I haven't delved too far into the gsVA/ssGSEA code, so that might be addressed there. Feel free to close if you do. But my thought is, could it be useful to implement a function to filter by cluster somehow? This mainly comes from how the background is computed. If we're running GSEA on a subset of immune cells within a tumor, for example, wouldn't the immune cells possibly have a higher background due to rows that are all zero for that cell being retained within the matrix? If this isn't the case, my apologies.

One way to accompany this would be to remove features that have < some user-defined parameter within an annotation grouping. So for example if one looks at a cell the function would remove rows that are all zero counts within its cluster/grouping before computing background

@ncborcherding ncborcherding added the enhancement New feature or request label Jul 31, 2024
@ncborcherding ncborcherding self-assigned this Jul 31, 2024
@ncborcherding
Copy link
Owner

Hey Alexei,

Interesting idea - I don't know if the zero values affect the rank based enrichment score. I would have to do testing to show possivle inflation. UCell has a upper cap on the number of genes ranked (n=1500), which might prevent that from happening, but I do not believe GSEA or GSVA have that. This might actually speed up computation time as well, as rank list generation would be smaller.

If you are interesting it trying things out or have code, let me know. I will add this to enhancement category, but will need to test things out before I start.

Nick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants