Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async hooks deprecated :( #12

Closed
yocontra opened this issue Jan 10, 2018 · 3 comments
Closed

async hooks deprecated :( #12

yocontra opened this issue Jan 10, 2018 · 3 comments

Comments

@yocontra
Copy link

nodejs/node#16972

node 10 will remove it entirely, so this library will cease to work. doubt they will change their mind at this point.
@naugtur
Copy link
Owner

naugtur commented Feb 18, 2018

It's just getting rid of old API, async hooks as a feature seem to be staying nodejs/diagnostics#124

@webtaculars
Copy link

Getting error due to deprecation of async-hooks. Anyone fixed this?

@naugtur
Copy link
Owner

naugtur commented Jun 3, 2018

@webtaculars you didn't get them from this.
blocked-at uses the part of async_hook that is not getting deprecated.

All tests pass in node 10 too.

@naugtur naugtur closed this as completed Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yocontra @naugtur @webtaculars