Fix #379, Align mismatched function prototype/implem. parameter names #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ** | ||
| ** Return: | ||
| ** (none) | ||
| */ | ||
|
|
||
| void CFE_PSP_Restart(uint32 reset_type) | ||
| void CFE_PSP_Restart(uint32 resetType) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
|
This will need rebase and likely minor conflict resolution once #381 is in. Planning to review once those updates can be made. |
thnkslprpt
force-pushed
the
fix-379-mismatched-function-prototype-parameter-names
branch
from
6cde7b4
to
7e9108a
Compare
skliper
approved these changes
Dec 18, 2023
skliper
added
the
CCB:Ready
|
@dzbaker @dmknutsen - Recommending for CCB review, thx! |
jphickey
approved these changes
Dec 19, 2023
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 5, 2024
*Combines:* sch_lab v2.5.0-rc4+dev83 osal v6.0.0-rc4+dev251 PSP v1.6.0-rc4+dev115 **Includes:** *cFS* - #725 *sch_lab* - nasa/sch_lab#164 - nasa/sch_lab#163 *osal* - nasa/osal#1438 *PSP* - nasa/PSP#380 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 8, 2024
*Combines:* sch_lab v2.5.0-rc4+dev83 osal v6.0.0-rc4+dev251 PSP v1.6.0-rc4+dev115 **Includes:** *cFS* - #725 *sch_lab* - nasa/sch_lab#164 - nasa/sch_lab#163 *osal* - nasa/osal#1438 *PSP* - nasa/PSP#380 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 10, 2024
*Combines:* sch_lab v2.5.0-rc4+dev83 osal v6.0.0-rc4+dev251 PSP v1.6.0-rc4+dev115 **Includes:** *cFS* - #725 *sch_lab* - nasa/sch_lab#164 - nasa/sch_lab#163 *osal* - nasa/osal#1438 *PSP* - nasa/PSP#380 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 10, 2024
*Combines:* sch_lab v2.5.0-rc4+dev83 osal v6.0.0-rc4+dev251 PSP v1.6.0-rc4+dev115 **Includes:** *cFS* - #725 *sch_lab* - nasa/sch_lab#164 - nasa/sch_lab#163 *osal* - nasa/osal#1438 *PSP* - nasa/PSP#380 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
thnkslprpt
deleted the
fix-379-mismatched-function-prototype-parameter-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
All flight code function declarations now match the implementations (incl. parameter names).
Testing performed
GitHub CI actions all passing successfully.
Local test build - 100% tests passing successfully.
Expected behavior changes
No change to behavior.
Code clarity and consistency improved.
System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS.
Contributor Info
Avi Weiss @thnkslprpt