feat: add optional offset param to varint.decode #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
approved these changes
Sep 20, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Sep 20, 2022
## [9.9.0](v9.8.1...v9.9.0) (2022-09-20) ### Features * add optional offset param to varint.decode ([#201](#201)) ([1e1b583](1e1b583))
|
🎉 This PR is included in version 9.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional
offsetparameter tovarint.decodeto allow decoding varints at arbitrary offsets without having to create intermediaryUint8Arrays.Whenever I have to deal with format that puts multiple varints e.g.
<code><size><bytes>I find myself having to read first varint then to read second I'm forced to create another Uint8Array view. With this change it would be possible to just specify offset and avoid creating unnecessary objects.