Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] DashboardLayout theme overrides issues #4066

Open
bharatkashyap opened this issue Sep 10, 2024 · 1 comment
Open

[core] DashboardLayout theme overrides issues #4066

bharatkashyap opened this issue Sep 10, 2024 · 1 comment
Labels
bug 🐛 Something doesn't work scope: toolpad-core Abbreviated to "core"

Comments

@bharatkashyap
Copy link
Member

bharatkashyap commented Sep 10, 2024

  1. Many styles from List and ListItem not being applied to Toolpad Core layout

Styling seems to be working differently from the current Material UI components.In the custom theme, there are many styles for List and ListItem , but these aren’t being applied to the layout.

Toolpad Core Theme app Material UI Dashboard Template App
  1. Custom theme breaking for focus and active states

The custom theme seems to be applied in most of the UI, but in some states such as focus and active are acting weird:

image
image

Search keywords:

@bharatkashyap bharatkashyap added the bug 🐛 Something doesn't work label Sep 10, 2024
@bharatkashyap bharatkashyap added this to the Toolpad Core Template milestone Sep 10, 2024
@prakhargupta1 prakhargupta1 added the scope: toolpad-core Abbreviated to "core" label Sep 10, 2024
@apedroferreira
Copy link
Member

Some of these styles are set so that the components look nicer by default, I expected them to be easily overridable in the theme.
If they're not that straightforward to override we can try maybe not setting some of them, not sure - maybe the app will still look ok enough with the default styles, but would have to check.
Otherwise I guess the template theme might be missing some styles that are needed to be used on top of Toolpad Core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work scope: toolpad-core Abbreviated to "core"
Projects
Status: Backlog
Development

No branches or pull requests

3 participants