Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Demo containers #13981

Open
zanivan opened this issue Jul 25, 2024 · 1 comment
Open

[DataGrid] Demo containers #13981

zanivan opened this issue Jul 25, 2024 · 1 comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation

Comments

@zanivan
Copy link
Contributor

zanivan commented Jul 25, 2024

Related page

https://mui.com/x/react-data-grid/

Kind of issue

Broken demo

Issue description

Almost all DataGrid demos have their top corners cropped—likely due to the demo container border-radius being larger than DataGrid's.

Screenshot 2024-07-25 at 10 06 12 Screenshot 2024-07-25 at 10 06 15

I think the demos are using the "bg": "inline" variant for demo container, and in addition to the cropped corners, we also have these two borders that feels off:

Screenshot 2024-07-25 at 10 06 21

Suggestion

Instead of using the "bg": "inline" variant, start using the "bg": "outlined" (this one), with a padding from the DataGrid and demo container

Search keywords: demo datagrid container border

@zanivan zanivan added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer labels Jul 25, 2024
@zanivan
Copy link
Contributor Author

zanivan commented Jul 25, 2024

About the corners, I realized it's not related to the demo container—it's actually the component. Adding overflow: 'clip' to DataGrid fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

1 participant