Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Support themeAugmentation #12070

Open
alexfauquette opened this issue Feb 15, 2024 · 0 comments
Open

[charts] Support themeAugmentation #12070

alexfauquette opened this issue Feb 15, 2024 · 0 comments
Labels
component: charts This is the name of the generic UI component, not the React module! RFC Request For Comments typescript waiting for 👍 Waiting for upvotes

Comments

@alexfauquette
Copy link
Member

alexfauquette commented Feb 15, 2024

The themeAugmentation works but in a bad way. Some typed properties does not work because of missing useThemeProps and lots of components added after the v6.alpha did not get added to the TS extends

I'm not entirely convinced. Plus the current strategy seems a bit chaotic.

Maybe it would be better to only target root components such as LineChart, BarChart, PieChart which have interesting props, and can customize nearly every thing with CSS selectors.

With this solution it is not possible to customize charts that mix lines and bars, or any other composition. But I expect people going that deep in customization to don't use themeing for charts styling.

I propose to wait for feedback about specific usecases in favor (or against) the support of themeAugmentation in charts before resuming the effort

Search keywords:

@alexfauquette alexfauquette added waiting for 👍 Waiting for upvotes RFC Request For Comments component: charts This is the name of the generic UI component, not the React module! labels Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! RFC Request For Comments typescript waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

2 participants