You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For the Crafty server library, the type check for tick on line 889 should be for "object" instead of "number" since setInterval returns an object in Node.js.
The text was updated successfully, but these errors were encountered:
skysyk
changed the title
Crafty server library (0.5.3) uses wrong type check for Crafty.timer.stop()
Crafty server library (0.5.3) uses wrong type check for Crafty.timer.stop() bug
Sep 9, 2016
skysyk
changed the title
Crafty server library (0.5.3) uses wrong type check for Crafty.timer.stop() bug
Crafty server library (0.5.3) uses wrong type check for Crafty.timer.stop()
Sep 9, 2016
The Node.js API docs on timers, section unref describe "The opaque value returned by setTimeout and setInterval", so I guess crafty should have the least expectations possible, because I understand "opaque" as "don't rely on (or even care about) specifics of the implementation". I usually only check truthiness on timer IDs.
For the Crafty server library, the type check for tick on line 889 should be for "object" instead of "number" since setInterval returns an object in Node.js.
The text was updated successfully, but these errors were encountered: