Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build_spec for tests of type 'file' #50

Closed
mrcjkb opened this issue Feb 27, 2023 · 1 comment · Fixed by #61
Closed

Improve build_spec for tests of type 'file' #50

mrcjkb opened this issue Feb 27, 2023 · 1 comment · Fixed by #61
Assignees
Labels
improvement Not a bug, but behaviour that can be improved

Comments

@mrcjkb
Copy link
Owner

mrcjkb commented Feb 27, 2023

The fix in #48 attempts to find the top-level describe node and runs that.
This might not be completely fool-proof, since it doesn't work if a single module has multiple top-level specs.

I'll have to take some extra time to think about how to get that working. Adding a --match for each test could be an option, but [...] it could exceed the maximum command line size in large test files.
Although it should be okay if I limit it to describes that don't have a parent describe.

Originally posted by @mrcjkb in #45 (comment)

@mrcjkb mrcjkb added the improvement Not a bug, but behaviour that can be improved label Mar 3, 2023
@mrcjkb mrcjkb self-assigned this Mar 3, 2023
@mrcjkb
Copy link
Owner Author

mrcjkb commented Mar 3, 2023

Should be done after #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Not a bug, but behaviour that can be improved
Projects
None yet
1 participant