This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Added backslash symbol and en-dash #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
approved these changes
Sep 26, 2018
|
@cvan I'm going to land this. If you have any issues they can be done as follow-up. |
cvan
reviewed
Nov 3, 2018
| @@ -19,7 +19,7 @@ | |||
| </Row> | |||
|
|
|||
| <Row> | |||
| <Key android:codes="45" android:keyLabel="-" android:keyEdgeFlags="left" android:horizontalGap="@dimen/keyboard_left_margin"/> | |||
| <Key android:codes="45" android:keyLabel="-" android:popupCharacters="-—" android:popupKeyboard="@xml/keyboard_popup" android:keyEdgeFlags="left" android:horizontalGap="@dimen/keyboard_left_margin"/> | |||
There was a problem hiding this comment.
how do you toggle this? I can't tell how to get the en-dash (–) to show up instead of the hyphen (-).
There was a problem hiding this comment.
you long press the hyphen and a popup should show with both symbols to choose. I guess the confusion comes because the hyphen and underscore are not easy to differentiate when not hovered. We might need to add the popup to both of them.
There was a problem hiding this comment.
gotcha, okay - I'm going to fiddle with this some more. I'll likely file some follow-up issues for the keyboard.
thanks for adding these, btw! 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #547 Added support for backslash and en-dash. Also added encoding/decoding search queries.