Crash service support #560
Conversation
keianhzo
force-pushed
the
crash-reporter
branch
3 times, most recently
from
4189ede
to
8b978b3
Compare
| } | ||
|
|
||
| if (!otherProcessesFound) { | ||
| Intent restartIntent = intent.setClass(CrashReporterService.this, VRBrowserActivity.class); |
There was a problem hiding this comment.
I don't understand this part. From the docs intent.setClass() returns it self. So I don't know why you need to reset all the values it already has.
intent.setClass(CrashReporterService.this, VRBrowserActivity.class).addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
startActivity(intent);
Should be the same?
There was a problem hiding this comment.
The original intent it targeted to the CrashReporterService so we need to retarget it for the VRBActivity but you are right we don't need to reset the rest of the values. Changed that.
|
Unfortunately we can't land this until we figure out a work around for the Go crash on first run issue. |
keianhzo
force-pushed
the
crash-reporter
branch
3 times, most recently
from
7482269
to
899a603
Compare
|
@keianhzo I pushed some fixes for Android P to this PR and made the crash reporter setting only grayed out on Oculus. Please take a look. |
|
@bluemarvin what's the issue with Android P? There is an infinite while loop in the latest commit that keeps on restarting the app whenever it's is closed after the first crash (crashparent). We should always let the crash service finish after handling the crash intent. |
|
I posted a fix for gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1493227 |
|
@bluemarvin added a fix for Android P. I still can see issues but only in API level 26. |
What issues are you seeing with 26? My S8 is running O right now. |
|
@bluemarvin it seems that system applies quite aggressive restrictions when the battery saver is on and the crash reporter service is killed upon second execution. |
|
@bluemarvin If it's working fine I guess we could land this and file a follow-up for testing in battery saving scenarios as I think this will only affect to Daydream "low end" clip-ins (S8). |
bluemarvin
force-pushed
the
crash-reporter
branch
from
125fc03
to
ba22b74
Compare
|
We need to wait for https://phabricator.services.mozilla.com/D7282 to land this |
keianhzo
force-pushed
the
crash-reporter
branch
from
6887e70
to
0f5df8f
Compare
Crash handler support.