This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 217
Fixes #3671 BrowserState-SessionStore sync #3669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
changed the title
Fixes BrowserState-SessionStore sync
Fixes #3671 BrowserState-SessionStore sync
Jul 13, 2020
bluemarvin
suggested changes
Jul 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If mSessionAdded
is in the wrong state, we should fix that instead of passing in boolean to override it.
app/src/common/shared/org/mozilla/vrbrowser/browser/engine/Session.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/org/mozilla/vrbrowser/browser/engine/Session.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not creating the mState in the constructor adds some risks. Parts of the code assume that mState is never null (e..g shutdown, dump listeners, or others)
keianhzo
force-pushed
the
v11/browser_state_sync
branch
from
July 14, 2020 11:33
0b8d765
to
bf5ff09
Compare
@MortimerGoro Shouldn't happen as we are calling |
MortimerGoro
approved these changes
Jul 14, 2020
bluemarvin
approved these changes
Jul 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3671
Make sure to test the following scenarios:
Logcat filtering by
SessionStore
will show theBrowserStore
-SessionStore
sync state including the alive vs suspended totals.Note: Suspended session will be alive at the
SessionStore
level but not at theBrowserStore
level, we remove them from theBrowserStore
when suspended, we only want alive ones there.