This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fixes #3637 Null check the alphabetic Caps Keyboard when switching shift #3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daoshengmu
suggested changes
Jul 7, 2020
app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/KeyboardWidget.java
Show resolved
Hide resolved
bluemarvin
pushed a commit
that referenced
this pull request
Jul 7, 2020
…ift (#3639) * Null check the alphabetic Caps Keyboard when switching shift * Return to alphabetic Thai keyboard after inserting a character
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3637 Null check the alphabetic caps Keyboard when entering a character.
Also allow the alphabetic caps keyboard to be dismissed when a key is entered, I've checked other keyboards and it seems to work the same way as the rest.