This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fixes #3620 Fixes #3634 Fix private session restore crash #3629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
changed the title
bluemarvin
approved these changes
Jul 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3620 Fixes #3634 We were setting the Session State and Uri to null in the
restoremethod just for handling default page loading inshouldLoadDefaultPagebut now inrestorewe consider a null Session State as a new session creation and we notify to theBrowserStorein hat case so we were trying to add a new session to theBrowserStorebut the session hasn't been removed from the store which triggered theBrowserStorecrash as it requires unique session ids.