Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Implement Spanish keyboard #1158

Merged
merged 2 commits into from
May 8, 2019
Merged

Implement Spanish keyboard #1158

merged 2 commits into from
May 8, 2019

Conversation

MortimerGoro
Copy link
Contributor

Note: This branch includes #1151 to make review easier. It will be removed when #1151 lands

@MortimerGoro MortimerGoro changed the title Spanish keyboard Implement Spanish keyboard May 6, 2019
@cvan cvan added this to the v1.2 milestone May 6, 2019
Copy link
Contributor

@cvan cvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 excellent work. I'll let @fernandojsg review the layout for Spanish. I noticed a few other issues:

  1. the Enter key appears in my OS locale (Mandarin) even though the Español keyboard is selected. (also noticed and reported in Implement keyboard language selection popup #1151 (review))

    image

  2. when ⇪ Caps Lock (enabled by double-clicking on the up arrow) is enabled, the modifier keys appear as uppercased, as expected. but when only the Shift key is active (enabled by single-clicking on the up arrow), the modifier keys appear lowercased. can we have the modifier keys appear in uppercase or lowercase depending on the Shift state as well?

    image

    image

  3. can the / keys appear on the same row as the other N/n modifier keys? it looks like a bug that the / keys appear isolated in a single row below the row for the modifier key.

    image

    image

    image

thanks!

@bluemarvin
Copy link
Contributor

We are going to start landing the keyboard PRs and then fixing in follow up issues since the current number of PRs makes testing challenging.

@cvan
Copy link
Contributor

cvan commented May 8, 2019

@bluemarvin @MortimerGoro: thanks, filed enhancement issues #1179 and #1180 to track the two items I identified above that will be useful to fix globally for the keyboards.

@philip-lamb philip-lamb mentioned this pull request May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants