You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 27, 2018. It is now read-only.
Note also that the options method - at line 360 - , and eventually the tools method implementing the same treatment of $icon_url - at line 566 - could be changed from:
wp-web-push/wp-web-push/wp-web-push-admin.php
Line 567 in fcfde51
Notice: Undefined variable: icon_url in ...plugins/web-push/wp-web-push-admin.php on line 567
If I'm not going wrong it can be fixed like so:
<input type="hidden" id="webpush_icon_custom" name="webpush_icon_custom" value="<?php echo $icon_option !== 'blog_icon' && $icon_option !== '' && $icon_option !== 'post_icon' ? $icon_option : ''; ?>" />
Or if it's better to be consistent with the
options
method at lines 311-314:wp-web-push/wp-web-push/wp-web-push-admin.php
Lines 311 to 314 in fcfde51
...adding the same
$icon_url
definition to thetools
method, maybe at line 533:wp-web-push/wp-web-push/wp-web-push-admin.php
Lines 531 to 533 in fcfde51
Note also that the
options
method - at line 360 - , and eventually thetools
method implementing the same treatment of$icon_url
- at line 566 - could be changed from:wp-web-push/wp-web-push/wp-web-push-admin.php
Line 360 in fcfde51
and:
wp-web-push/wp-web-push/wp-web-push-admin.php
Line 566 in fcfde51
to:
<label><input type="radio" name="webpush_icon" value="custom" <?php echo $icon_url ? 'checked' : ''; ?> /> <?php _e('Custom:'); ?></label>
The text was updated successfully, but these errors were encountered: