Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests more predictable by removing setState callbacks #10733

Closed
kumar303 opened this issue Sep 7, 2017 · 1 comment
Closed

Make tests more predictable by removing setState callbacks #10733

kumar303 opened this issue Sep 7, 2017 · 1 comment
Assignees
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Milestone

Comments

@kumar303
Copy link
Contributor

kumar303 commented Sep 7, 2017

I don't think our tests should rely on setState() being synchronous as it's unclear that this will always work in enzyme as its libraries evolve and get upgraded.

We have a few problems in the test suite related to this but first let's try not to rely on setState callbacks.

Here are two places that (hopefully) can be fixed with different approaches:

@willdurand
Copy link
Member

should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

No branches or pull requests

4 participants