Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define categories explicitly #64

Open
boolean5 opened this issue Jul 27, 2020 · 2 comments
Open

Define categories explicitly #64

boolean5 opened this issue Jul 27, 2020 · 2 comments

Comments

@boolean5
Copy link
Contributor

There is a plan to stop falling back to using the default categories when a configuration section does not have a categories key. Instead, shavar-list-creation will raise a ValueError in this case.

We should go through the configuration files in this repo and make sure that all sections are defining their categories explicitly.

Regarding sections tracking-protection-baseeff and tracking-protection-basew3c, after a discussion with @englehardt and @say-yawn, we decided to remove them, as they are not used anymore.

@say-yawn
Copy link
Contributor

@englehardt can you comment whether or not:

  • tracking-protection-contentw3c
  • tracking-protection-contenteff
    configs can also be removed?

@englehardt
Copy link
Contributor

@say-yawn We don't use these anymore, so they can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants