RedeemPool, Redeemer proxy contract and tests #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xsarvesh
changed the title
deepesh-kn
reviewed
Sep 5, 2019
There was a problem hiding this comment.
Very nice code 👍 .
I scanned through the contract code only, will go through the tests as well, providing the feedback so that you can be unblocked.
Maybe you want to consider implementing the proxy pattern for RedeemProxy to reduce the gas consumption. #773
0xsarvesh
changed the title
This was referenced Sep 6, 2019
deepesh-kn
reviewed
Sep 9, 2019
test_integration/03_redeem_and_unstake/02_redeem_and_unstake_with_redeem_composer.js
Outdated
Show resolved
Hide resolved
test_integration/03_redeem_and_unstake/utils/accept_redeem_assertion.js
Outdated
Show resolved
Hide resolved
test_integration/03_redeem_and_unstake/utils/request_redeem_assertion.js
Outdated
Show resolved
Hide resolved
deepesh-kn
reviewed
Sep 9, 2019
deepesh-kn
reviewed
Sep 9, 2019
0xsarvesh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #788
This PR implements
Redeem Composer,Redeemer proxy contractand integration of redeem flow with redeem composer.These contracts are similar to OST composer and Staker proxy, however there are few deviations.
stakeRequestmapping in the OST composer contract seems redundant. I haven't added this storage in Redeem composer contracthttps://github.com/mosaicdao/mosaic-contracts/blob/45023774d47ab8322bfb8cb495175fdf62b8a509/contracts/gateway/OSTComposer.sol#L83
AceeptRedeemRequestis a payable function.