We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Here is a list of potential refactors:
msgSender()
msg.sender
_convertToAssetsWithFeeAccrue
accruedFeeShares
_supplyBalance
_suppliable
_staticWithdrawMorpho
The text was updated successfully, but these errors were encountered:
Agreed with 1 I need to check for 2
Regarding 3,4,5: I disagree that because a function can be inlined, it should be defactorized. Factorizing them also provides documentation
Sorry, something went wrong.
Aligned with @Rubilmax
If we apply 4 & 5 we should also inline _supplyMorpho and _withdrawMorpho
_supplyMorpho
_withdrawMorpho
MerlinEgalite
Successfully merging a pull request may close this issue.
Here is a list of potential refactors:
msgSender()
ormsg.sender
, currently both are used #238_convertToAssetsWithFeeAccrue
inaccruedFeeShares
. It requires to rename_convertToAssetsWithFeeAccrue
to a more general name_supplyBalance
could be inlined, it’s a one liner_suppliable
could be inlined, it is used only once_staticWithdrawMorpho
could be inlined, it is used only onceThe text was updated successfully, but these errors were encountered: