Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] sk_ipoint_t and sk_isize_t should use integer members #991

Closed
ngocdaothanh opened this issue Nov 3, 2019 · 1 comment
Closed

[BUG] sk_ipoint_t and sk_isize_t should use integer members #991

ngocdaothanh opened this issue Nov 3, 2019 · 1 comment
Milestone

Comments

@ngocdaothanh
Copy link

See: https://github.com/mono/skia/blob/xamarin-mobile-bindings/include/c/sk_types.h

Current code:

typedef struct {
    float   x;
    float   y;
} sk_ipoint_t;

typedef struct {
    float   w;
    float   h;
} sk_isize_t;

typedef struct {
    int32_t left;
    int32_t top;
    int32_t right;
    int32_t bottom;
} sk_irect_t;

Coincidentally, the size of float is 32.
But for correctness, sk_ipoint_t and sk_isize_t should use int32_t.

@mattleibow
Copy link
Contributor

Thanks for the issue and PR. Merged!

@mattleibow mattleibow added this to the v1.68.1 milestone Nov 21, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants