Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LocalDomainError and SimulationError for improved exception handling. #92

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

SlipperyGnome
Copy link
Member

This change is for the issue #48
The catch blocks for SimulationError and LocalDomainError in this file had messy and repetitive codes which are now defined in one function _handleFLINTException. This change is done only for one set of try/catch blocks for now.

Signed-off-by: Debolina Ghatuary debolinaghatuary200011@gmail.com

Signed-off-by: Debolina Ghatuary <debolinaghatuary200011@gmail.com>
@aornugent
Copy link
Contributor

aornugent commented Apr 20, 2021

@RobboW - is there anyone on your team available to review @SlipperyGnome's changes? If acceptable, it'd be great to understand where else the templated exception function can be used and what a complete PR should contain.

@RobboW
Copy link

RobboW commented Apr 20, 2021 via email

Signed-off-by: Debolina Ghatuary <debolinaghatuary200011@gmail.com>
Signed-off-by: Debolina Ghatuary <debolinaghatuary200011@gmail.com>
@aornugent aornugent changed the title Changes in the spatialtiledlocaldomaincontroller.cpp Refactor LocalDomainError and SimulationError for improved exception handling. May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants