Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:56 Extendable Land Unit Area #84

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kartikeysaran
Copy link

This PR Fixes #56

Signed-off-by: kartikeysaran <sarankartikey@gmail.com>
@allcontributors
Copy link
Contributor

@kartikeysaran

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

3 similar comments
@allcontributors
Copy link
Contributor

@kartikeysaran

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@allcontributors
Copy link
Contributor

@kartikeysaran

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@allcontributors
Copy link
Contributor

@kartikeysaran

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@kartikeysaran
Copy link
Author

@all-contributors please add <@kartikeysaran> for

@allcontributors
Copy link
Contributor

@kartikeysaran

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@kartikeysaran
Copy link
Author

@all-contributors please add @kartikeysaran for code

@allcontributors
Copy link
Contributor

@kartikeysaran

I've put up a pull request to add @kartikeysaran! 🎉

@aornugent
Copy link
Contributor

@shubhamkarande13 - could you please take a look at this? @kartikeysaran - you might need to add some explanation how your changes fix the issue.

@shubhamkarande13
Copy link
Member

@kartikeysaran
@leitchy would like to allow the user to define a variable that points to the Area to be used, which can be changed in the config file with "landUnitAreaVariable": "spatial_layer_area",.

Your commit does not involve the functionality to get this variable from the config file. 👎🏼
Please come try to come up with an alternative solution!

Cheers!

@aornugent
Copy link
Contributor

Thanks @shubhamkarande13 - do you have an example of how config variables are used? Perhaps in FLINT.example?

@shubhamkarande13
Copy link
Member

@kartikeysaran
Please have a look at the config files.
Base test module RothC module

@kartikeysaran
Copy link
Author

@kartikeysaran
Please have a look at the config files.
Base test module RothC module

Okay will update the code accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants