xPDOCacheManager's lockFile fails when $_SERVER['SERVER_ADDR'] is an IPv6 address

[ttyiav]

xPDOCacheManager's lockFile method (called when use_flock is FALSE) generates bad filename when $_SERVER['SERVER_ADDR'] is an IPv6 address.

revolution/core/xpdo/cache/xpdocachemanager.class.php

Line 279 in 7826c3e

$myPID = (XPDO_CLI_MODE || !isset($_SERVER['SERVER_ADDR']) ? gethostname() : $_SERVER['SERVER_ADDR']) . '.' . getmypid();

IPv6 addresses contain ':' symbols which are not allowed on Windows filesystems.
$tmpLockFile variable could be sanitized in any possible way, for example like here

revolution/core/xpdo/cache/xpdocachemanager.class.php

Line 315 in 7826c3e

return $lockDir . preg_replace('/\W/', '_', $file) . $this->getOption(xPDO::OPT_LOCKFILE_EXTENSION, $options, '.lock');

or with str_replace().

Environment

Any MODX version containing the xPDOCacheManager::lockFile,
IPv6 enabled server installation,
IPv6 client.

[alroniks]

As it moved to xPDO, I am closing this one. This closed issue still will be available by the link.