Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert default glob to match Mocha-5.2 #3754

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Conversation

plroebuck
Copy link
Contributor

Description of the Change

The old glob 'test' would allow "test.js" to be used by default (rather than requiring spec file be
placed inside "test" directory).

In minimalist repos, users were simply using "test.js" rather than "test/<file>.js", allowing...

$ mocha

Alternate Designs

NA

Why should this be in core?

NA - already there

Benefits

Restore compatibility with previous releases.
Prevent a boatload of more issues from minimalist repositories using Mocha.

Possible Drawbacks

None

Applicable issues

Fixes #3750
semver-patch

The old glob 'test' would allow 'test.js' to be used by default (rather than requiring file be
placed inside "test" directory.

Fixes #3750
@plroebuck plroebuck added area: usability concerning user experience or interface semver-patch implementation requires increase of "patch" version number; "bug fixes" area: node.js command-line-or-Node.js-specific labels Feb 20, 2019
@plroebuck plroebuck added this to the next milestone Feb 20, 2019
@plroebuck plroebuck self-assigned this Feb 20, 2019
@plroebuck
Copy link
Contributor Author

This is just the patch itself. Do we want to document this "feature", or simply treat it as a
"laissez-faire" possibility?

@boneskull boneskull added the type: bug a defect, confirmed by a maintainer label Feb 20, 2019
@boneskull boneskull merged commit 34afb1a into master Feb 20, 2019
@boneskull
Copy link
Contributor

no, whatever, it's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: node.js command-line-or-Node.js-specific area: usability concerning user experience or interface semver-patch implementation requires increase of "patch" version number; "bug fixes" type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants