Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: split up dockerfile frontend tests more #2230

Closed
tonistiigi opened this issue Jul 7, 2021 · 3 comments · Fixed by #2232
Closed

CI: split up dockerfile frontend tests more #2230

tonistiigi opened this issue Jul 7, 2021 · 3 comments · Fixed by #2232

Comments

@tonistiigi
Copy link
Member

Currently longest-running items in CI are:

  • build / test (./frontend/dockerfile, dockerfile) (pull_request) Successful in 23m
  • build / test (./frontend/dockerfile) (pull_request) Successful in 21m
  • build / cross (pull_request) Successful in 11m
  • build / test-os (windows-latest) (pull_request) Successful in 8m
  • build / image (pull_request) Successful in 8m
  • ...

So the top 2 items take >2x the rest. As these are tests they also block other steps. It might be good to try to split them more into pieces that run in parallel(ideally 4).

@crazy-max

@crazy-max
Copy link
Member

Agree, will work on that. I also wonder if we should start thinking about moving the dockerfile-frontend to a dedicated repo, maybe keep tests to keep track of regressions.

@crazy-max
Copy link
Member

Oh looks like it was already in the pipe #163

@tonistiigi
Copy link
Member Author

Oh looks like it was already in the pipe #163

I conceptually agree but still worried that this will cause maintenance issues. For testing this does not matter though, even if a bunch of these tests would be in a separate repo we would still need to invoke them on BuildKit PR as they provide a lot to the test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants