diff --git a/frontend/gateway/gateway.go b/frontend/gateway/gateway.go index 93b5da013d67..ac45ef93f2de 100644 --- a/frontend/gateway/gateway.go +++ b/frontend/gateway/gateway.go @@ -328,11 +328,8 @@ func (gf *gatewayFrontend) Solve(ctx context.Context, llbBridge frontend.Fronten } } - lbf, ctx, err := serveLLBBridgeForwarder(ctx, llbBridge, exec, gf.workers, inputs, sid, sm) - defer lbf.conn.Close() //nolint - if err != nil { - return nil, err - } + lbf, ctx := serveLLBBridgeForwarder(ctx, llbBridge, exec, gf.workers, inputs, sid, sm) + defer lbf.conn.Close() defer lbf.Discard() mdmnt, release, err := metadataMount(frontendDef) @@ -498,7 +495,7 @@ func newBridgeForwarder(ctx context.Context, llbBridge frontend.FrontendLLBBridg return lbf } -func serveLLBBridgeForwarder(ctx context.Context, llbBridge frontend.FrontendLLBBridge, exec executor.Executor, workers worker.Infos, inputs map[string]*opspb.Definition, sid string, sm *session.Manager) (*llbBridgeForwarder, context.Context, error) { +func serveLLBBridgeForwarder(ctx context.Context, llbBridge frontend.FrontendLLBBridge, exec executor.Executor, workers worker.Infos, inputs map[string]*opspb.Definition, sid string, sm *session.Manager) (*llbBridgeForwarder, context.Context) { ctx, cancel := context.WithCancelCause(ctx) lbf := newBridgeForwarder(ctx, llbBridge, exec, workers, inputs, sid, sm) serverOpt := []grpc.ServerOption{ @@ -521,7 +518,7 @@ func serveLLBBridgeForwarder(ctx context.Context, llbBridge frontend.FrontendLLB cancel(errors.WithStack(context.Canceled)) }() - return lbf, ctx, nil + return lbf, ctx } type pipe struct { diff --git a/frontend/gateway/grpcclient/client.go b/frontend/gateway/grpcclient/client.go index cb857a094d59..c658c346e169 100644 --- a/frontend/gateway/grpcclient/client.go +++ b/frontend/gateway/grpcclient/client.go @@ -1262,7 +1262,7 @@ func grpcClientConn(ctx context.Context) (context.Context, *grpc.ClientConn, err cc, err := grpc.DialContext(ctx, "localhost", dialOpts...) if err != nil { - return nil, nil, errors.Wrap(err, "failed to create grpc client") + return ctx, nil, errors.Wrap(err, "failed to create grpc client") } ctx, cancel := context.WithCancelCause(ctx) diff --git a/session/grpc.go b/session/grpc.go index 48f151092f46..8f3c61cd3af3 100644 --- a/session/grpc.go +++ b/session/grpc.go @@ -58,7 +58,7 @@ func grpcClientConn(ctx context.Context, conn net.Conn) (context.Context, *grpc. cc, err := grpc.DialContext(ctx, "localhost", dialOpts...) if err != nil { - return nil, nil, errors.Wrap(err, "failed to create grpc client") + return ctx, nil, errors.Wrap(err, "failed to create grpc client") } ctx, cancel := context.WithCancelCause(ctx) diff --git a/util/leaseutil/manager.go b/util/leaseutil/manager.go index 42381b6d07ac..43e7f0c21c27 100644 --- a/util/leaseutil/manager.go +++ b/util/leaseutil/manager.go @@ -20,7 +20,7 @@ func WithLease(ctx context.Context, ls leases.Manager, opts ...leases.Opt) (cont lr, ctx, err := NewLease(ctx, ls, opts...) if err != nil { - return nil, nil, err + return ctx, nil, err } return ctx, func(ctx context.Context) error { @@ -31,7 +31,7 @@ func WithLease(ctx context.Context, ls leases.Manager, opts ...leases.Opt) (cont func NewLease(ctx context.Context, lm leases.Manager, opts ...leases.Opt) (*LeaseRef, context.Context, error) { l, err := lm.Create(ctx, append([]leases.Opt{leases.WithRandomID(), leases.WithExpiration(time.Hour)}, opts...)...) if err != nil { - return nil, nil, err + return nil, ctx, err } ctx = leases.WithLease(ctx, l.ID)