Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Remove all {DiscriMiner} learners #2840

Merged
merged 1 commit into from
Jul 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ Suggests:
Cubist,
deepnet,
DiceKriging,
DiscriMiner,
e1071,
earth,
elasticnet,
Expand Down
9 changes: 0 additions & 9 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ S3method(makeRLearner,classif.gamboost)
S3method(makeRLearner,classif.gaterSVM)
S3method(makeRLearner,classif.gausspr)
S3method(makeRLearner,classif.gbm)
S3method(makeRLearner,classif.geoDA)
S3method(makeRLearner,classif.glmboost)
S3method(makeRLearner,classif.glmnet)
S3method(makeRLearner,classif.h2o.deeplearning)
Expand All @@ -193,7 +192,6 @@ S3method(makeRLearner,classif.kknn)
S3method(makeRLearner,classif.knn)
S3method(makeRLearner,classif.ksvm)
S3method(makeRLearner,classif.lda)
S3method(makeRLearner,classif.linDA)
S3method(makeRLearner,classif.logreg)
S3method(makeRLearner,classif.lssvm)
S3method(makeRLearner,classif.lvq1)
Expand All @@ -211,7 +209,6 @@ S3method(makeRLearner,classif.plr)
S3method(makeRLearner,classif.plsdaCaret)
S3method(makeRLearner,classif.probit)
S3method(makeRLearner,classif.qda)
S3method(makeRLearner,classif.quaDA)
S3method(makeRLearner,classif.rFerns)
S3method(makeRLearner,classif.randomForest)
S3method(makeRLearner,classif.ranger)
Expand Down Expand Up @@ -370,7 +367,6 @@ S3method(predictLearner,classif.gamboost)
S3method(predictLearner,classif.gaterSVM)
S3method(predictLearner,classif.gausspr)
S3method(predictLearner,classif.gbm)
S3method(predictLearner,classif.geoDA)
S3method(predictLearner,classif.glmboost)
S3method(predictLearner,classif.glmnet)
S3method(predictLearner,classif.h2o.deeplearning)
Expand All @@ -381,7 +377,6 @@ S3method(predictLearner,classif.kknn)
S3method(predictLearner,classif.knn)
S3method(predictLearner,classif.ksvm)
S3method(predictLearner,classif.lda)
S3method(predictLearner,classif.linDA)
S3method(predictLearner,classif.logreg)
S3method(predictLearner,classif.lssvm)
S3method(predictLearner,classif.lvq1)
Expand All @@ -399,7 +394,6 @@ S3method(predictLearner,classif.plr)
S3method(predictLearner,classif.plsdaCaret)
S3method(predictLearner,classif.probit)
S3method(predictLearner,classif.qda)
S3method(predictLearner,classif.quaDA)
S3method(predictLearner,classif.rFerns)
S3method(predictLearner,classif.randomForest)
S3method(predictLearner,classif.ranger)
Expand Down Expand Up @@ -623,7 +617,6 @@ S3method(trainLearner,classif.gamboost)
S3method(trainLearner,classif.gaterSVM)
S3method(trainLearner,classif.gausspr)
S3method(trainLearner,classif.gbm)
S3method(trainLearner,classif.geoDA)
S3method(trainLearner,classif.glmboost)
S3method(trainLearner,classif.glmnet)
S3method(trainLearner,classif.h2o.deeplearning)
Expand All @@ -634,7 +627,6 @@ S3method(trainLearner,classif.kknn)
S3method(trainLearner,classif.knn)
S3method(trainLearner,classif.ksvm)
S3method(trainLearner,classif.lda)
S3method(trainLearner,classif.linDA)
S3method(trainLearner,classif.logreg)
S3method(trainLearner,classif.lssvm)
S3method(trainLearner,classif.lvq1)
Expand All @@ -652,7 +644,6 @@ S3method(trainLearner,classif.plr)
S3method(trainLearner,classif.plsdaCaret)
S3method(trainLearner,classif.probit)
S3method(trainLearner,classif.qda)
S3method(trainLearner,classif.quaDA)
S3method(trainLearner,classif.rFerns)
S3method(trainLearner,classif.randomForest)
S3method(trainLearner,classif.ranger)
Expand Down
6 changes: 1 addition & 5 deletions tests/testthat/test_learners_all_classif.R
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,9 @@ test_that("learners work: classif", {
y = as.factor(rep(c("a", "b"), each = 5))), target = "y")
lrns = listLearnersCustom(min.task, create = TRUE)
# FIXME: classif.boosting: Remove if bug is removed in adabag!
# FIXME: classif.quaDA: Remove if bug is removed in DiscriMiner::quaDA!
# FIXME: classif.rknn: Remove if bug is removed in rknn::rknn!
# classif.cvglmnet does not claim to work for 1d problems
# classif.dbnDNN, classif.evtree, classif.geoDA, classif.linDA, classif.lqa
# classif.dbnDNN, classif.evtree, classif.lqa
# (not im mlr anymore),
# classif.lvq1, classif.mda (maybe only subset error),
# classif.pamr (maybe only subset error),
Expand All @@ -108,14 +107,11 @@ test_that("learners work: classif", {
"classif.cvglmnet",
"classif.dbnDNN",
"classif.evtree",
"classif.geoDA",
"classif.glmnet",
"classif.linDA",
"classif.lvq1",
"classif.mda",
"classif.pamr",
"classif.plsdaCaret",
"classif.quaDA",
"classif.rotationForest",
"classif.rknn")
lrns_sub = lrns[extractSubList(lrns, "id", simplify = TRUE) %nin% not.working]
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.