Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta-geom: Make a single stat_slabinterval / geom_slabinterval from the hacked violins/densities, pointinterval, and eye geoms #84

Closed
41 tasks done
mjskay opened this issue Oct 16, 2017 · 1 comment
Closed
41 tasks done

Meta-geom: Make a single stat_slabinterval / geom_slabinterval from the hacked violins/densities, pointinterval, and eye geoms #84

mjskay opened this issue Oct 16, 2017 · 1 comment
Milestone
Next release

Comments

@mjskay
Copy link
Owner

mjskay commented Oct 16, 2017 •
edited
Loading

TODOs:

  • add a few more shortcuts (and update the family overview image):
    • stat_dist_interval[h]
    • stat_dist_pointinterval[h]
    • stat_slab[h]
    • stat_dist_slab[h]
    • geom_slab[h] ?
  • tests please:
    • break functions out so can see coverage
    • tests for scale transformations in stats with things like scale_x_log10()
  • add examples to new geom docs (search for TODO). Can pull from slabinterval vignette. Then point people in the vignette direction from the examples
  • output n so people can use n*density if desired
  • add a few more of the specific aesthetics (plus test):
    • point_alpha
    • interval_alpha
    • slab_fill
    • slab_alpha
  • reference in README, other vignettes (even if just pointing to slabinterval vignette)
  • document aesthetics for geom_slabinterval and sub-geoms
  • change old geom_[half]eye[h] refs to stat_[half]eye[h]
  • speed up gradient by using polygon directly for groups
  • make thickness a different stat
  • build cool new stuff the meta-geom makes easy:
  • build ridiculous meta-geom
  • decide on good name
  • implement a key / legend drawing function
    • remove old draw_key funcs
  • look into dropping ggstance stuff in docs (except dodgev)
  • document use of position dodge
  • reimplement base geoms (not stats) on meta-geom
  • undo weird interval_size scale and revert to fatten / etc
  • fix existing stats
  • build generic meta-stat (and make it faster)
    • rebuild stat_pointinterval and stat_interval on top of this
  • add in depracted argument alias for relative_scale -> scale
  • fix behavior of position_dodge for pointintervals / eyes / halfeyes (it now works for intervals, see Make stat_interval provide width automatically for position='dodge' #180)
  • Make sure aesthetics for different parts of the geom are exposed (fill, alpha, outline, etc)
  • make sure defaults only work when corresponding column exists; see failure of geom_pointinterval in readme and make a test.
@mjskay mjskay self-assigned this Oct 16, 2017
@mjskay mjskay changed the title Merge the hacked violins/densities and eye geoms Make a single stat_density_interval / geom_density_interval from the hacked violins/densities, pointinterval, and eye geoms Aug 10, 2018
@mjskay mjskay removed their assignment Aug 10, 2018
@mjskay mjskay mentioned this issue Aug 10, 2018
Closed
@mjskay mjskay mentioned this issue Nov 16, 2018
Closed
@mjskay mjskay mentioned this issue Mar 19, 2019
Closed
@mjskay mjskay mentioned this issue Apr 1, 2019
Closed
@mjskay mjskay mentioned this issue Jul 3, 2019
Closed
@mjskay mjskay changed the title Make a single stat_density_interval / geom_density_interval from the hacked violins/densities, pointinterval, and eye geoms Meta-geom: Make a single stat_density_interval / geom_density_interval from the hacked violins/densities, pointinterval, and eye geoms Jul 12, 2019
mjskay added a commit that referenced this issue Jul 12, 2019
@mjskay
initial implementation of meta-geom, towards #84
b2e8a96
mjskay added a commit that referenced this issue Jul 13, 2019
@mjskay
meta-geom words with area, point, and interval; towards #84
15c49bb
@mjskay mjskay added this to the Next release milestone Jul 14, 2019
mjskay added a commit that referenced this issue Jul 23, 2019
@mjskay
work on lineribbon, interval, and pointinterval, towards #84
65436a4
mjskay added a commit that referenced this issue Jul 23, 2019
@mjskay
pointinterval and interval working with slabinterval, towards #84
088d60a
mjskay added a commit that referenced this issue Jul 24, 2019
@mjskay
intervalh + docs cleanup, towards #84
a9ca5a1
mjskay added a commit that referenced this issue Jul 24, 2019
@mjskay
key glyphs for slabinterval, towards #84
fdc35d0
mjskay added a commit that referenced this issue Jul 25, 2019
@mjskay
the beginnings of a meta-stat, towards #84
d016367
mjskay added a commit that referenced this issue Jul 26, 2019
@mjskay
working intervals in stat_slabinterval; towards #84
326ce0d
mjskay added a commit that referenced this issue Jul 27, 2019
@mjskay
stat_distinterval and aliases, towards #84
6f772a3
mjskay added a commit that referenced this issue Jul 28, 2019
@mjskay
working stat_sample_slabinterval and derivatives, towards #84
1c4a112
mjskay added a commit that referenced this issue Jul 28, 2019
@mjskay
working automatic key glyphs, toward #84
557848a
mjskay added a commit that referenced this issue Jul 28, 2019
@mjskay
rewrite remaining stats in terms of slabinterval, towards #84
0f4291f
mjskay added a commit that referenced this issue Jul 30, 2019
@mjskay
stat_histinterval[h]; towards #84, closes #162
6dc7e9f
@mjskay mjskay changed the title Meta-geom: Make a single stat_density_interval / geom_density_interval from the hacked violins/densities, pointinterval, and eye geoms Meta-geom: Make a single stat_slabinterval / geom_slabinterval from the hacked violins/densities, pointinterval, and eye geoms Jul 30, 2019
@mjskay mjskay mentioned this issue Jul 30, 2019
Closed
@mjskay
Copy link
Owner Author

mjskay commented Aug 4, 2019

Done for now --- everything else relevant has been split into other issues

@mjskay mjskay closed this as completed Aug 4, 2019
mjskay added a commit that referenced this issue Aug 4, 2019
@mjskay
finish off shortcut geoms and family picture for #84
08d2e05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next release
Development

No branches or pull requests
1 participant
@mjskay