Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistency in ETL functions regarding data["attribute"] vs data.get("attribute") #515

Open
mbertrand opened this issue Feb 16, 2024 · 0 comments

Comments

@mbertrand
Copy link
Member

mbertrand commented Feb 16, 2024

Description/Context

Some ETL transform functions use the format source_data["attribute"] for some/all attributes- this is likely because the attribute is always supposed to be present in the source data, and the function should fail if it isn't, to indicate that something is wrong with the source data.

Other functions use the format source_data.get("attribute") for some/all attributes - likely because the attribute might not always be present in the source data, and this is considered okay for the particular source.

It might be good to double-check on these and make sure they are still used appropriately per data source and per attribute, and make them more consistent where applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant