Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot remove a map service if more than one map has been created. #334

Closed
sjpinizzotto opened this issue Jun 20, 2017 · 4 comments
Closed
Assignees
Milestone

Comments

@sjpinizzotto
Copy link

Create two maps. Add a map service to each map. Try to remove the services from both maps. You cannot in API because getMapServices reports no layers on one of the maps. But even if you had the map service you would not be able to remove it.

Internally the core is sending back the default overlay where the services should be added. However in the v2 to v3 upgrade it looks like it was never accounted for that multiple maps would be returning their overlays. The default overlay gets overwritten, and the api can never send the correct overlay for one of the maps, as it has been overwritten.

Ideally each map should know the overlay for the wms services so that this issue does not occur.

@alberto-acevedo
Copy link
Contributor

Fixed as suggested by Steve.

Test case:

Use branch 240

Open the Cesium map Add a WMS service.
Open the Leaflet map Add a WMS service.
Remove the services from both maps. The test is a success if all services are removed from the both engines.

@mubinakhan
Copy link

Reinetrgate

@alberto-acevedo
Copy link
Contributor

Merged into the dev branch. Closing this issue.

1 similar comment
@alberto-acevedo
Copy link
Contributor

Merged into the dev branch. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants