-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge async and not-async implementation #601
Comments
What do you mean by this? Maybe I can help |
@duszekmestre ❤thanks, e.g. ExcelOpenXmlSheetWriter.Async.cs and ExcelOpenXmlSheetWriter.cs, their logic and code 99% same, but miniexcel needs duplicate code to use |
Yes - I tried to do this but I have limited time for doing this. Some code can be reused and in latest PR i refactor one of the method to prepare string values to write them to the writer. |
I started to reuse code in PR #602 In the next part I'll try to reuse code between different types of objects on saving. |
I think it is not possible to completely reuse same code. Async/await method should be written separately. The only thing which is possible is creating same codebase to generate XML strings for both implementations to reuse and easier maintenance. I saw that different types (data reader, data table, enumerable) are managed separately so many errors are done because of lack of implementation to one of them. This the hardest and most important thing to rewrite. If you have any other idea please share with me. |
Yes, my first idea is we can only maintain |
No description provided.
The text was updated successfully, but these errors were encountered: