Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less obscure behaviour while copying the assets #473

Closed
lorenzosinisi opened this issue Nov 3, 2016 · 1 comment
Closed

Less obscure behaviour while copying the assets #473

lorenzosinisi opened this issue Nov 3, 2016 · 1 comment

Comments

@lorenzosinisi
Copy link
Contributor

I wanted to open a pull request making the task :assets_precompile (For Rails) more explicit.

Right now if the task :assets_precompile is skipped the output says Skipping asset precompilation while what is happening is that the previous public/assets folder is copied into the new one. This is a very obscrure behaviour and outputting what is 'actually' happening will prevent confusion. What do you think?

in tasks/mina/rails.rb

66 -   skip: %{echo "-----> Skipping asset precompilation"},
66 +   skip: %{echo "-----> Skipping asset precompilation and cloning from previous assets folder."},
@d4be4st
Copy link
Member

d4be4st commented Nov 3, 2016

This is the way 0.3.x version has done.
In 1.0.0 assets are link shared and not copied.

@d4be4st d4be4st closed this as completed Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants