Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trimming] Make Microsoft.Graph.Beta for .NET trimming compatible. #748

Closed
chrisgriffis opened this issue Oct 26, 2023 · 2 comments
Closed

Comments

@chrisgriffis
Copy link

chrisgriffis commented Oct 26, 2023

Is your feature request related to a problem? Please describe.

Yes, We're (@RobsonPontin) writing a WinUI 3 Application (using Windows App SDK) which must be published as trimmed since .NET supports it, but the Microsoft.Graph dependency does not support it and give me trim warnings.

Describe the solution you'd like

Fix all cases using reflection and every single trim warning to make the SDK fully trimmable.
This is a requirement for Native AOT which is coming soon for Windows App SDK with .NET 8.

Describe alternatives you've considered

The alternative would be not using the .NET SDK but using REST API instead, but we should strive to improve the SDK instead.

Additional context

link to the completed request in release/v1.0 sdk
[Trimming] Make Microsoft.Graph for .NET trimming compatible.

@andrueastman
Copy link
Member

Thanks for raising this @chrisgriffis

I believe this should have been resolved with #746 and available via https://www.nuget.org/packages/Microsoft.Graph.Beta/5.53.0-preview.
Any chance you can confirm if you have any issues with the latest release?

@andrueastman
Copy link
Member

Confirmed as resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants