Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Running tests doesn't re-sort if sort order is "by Status" #139648

Closed
stefanhaller opened this issue Dec 22, 2021 · 2 comments
Closed

Testing: Running tests doesn't re-sort if sort order is "by Status" #139648

stefanhaller opened this issue Dec 22, 2021 · 2 comments
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Milestone
January 2022

Comments

@stefanhaller
Copy link
Contributor

  • VS Code Version: 1.64.0-insider (commit 7b9e5c3)

Steps to Reproduce:

  • Open test panel
  • Set sort order to "Sort by Status"
  • Make a test fail that used pass
  • Run either this test alone, or all tests

Expected: the newly failing test bubbles to the top of the list
Actual: the test stays where it is. Setting the sort order to something else and then back to "by Status" does make it bubble to the top.
@stefanhaller
Copy link
Contributor Author

Ping @connor4312

@stefanhaller
Copy link
Contributor Author

Bisecting shows that this broke with ddaf6a2. Which seems plausible, as that commit removed a call to tree.resort in onResultsChanged.

@stefanhaller stefanhaller mentioned this issue Dec 23, 2021
Closed
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels Dec 24, 2021
@connor4312 connor4312 added this to the January 2022 milestone Dec 24, 2021
@amunger amunger added the verified Verification succeeded label Jan 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Projects
None yet
Milestone
January 2022
Development

No branches or pull requests
4 participants
@stefanhaller @amunger @connor4312 and others