-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update R Docker image and vscode-r recommended settings #732
Conversation
@kmehant as the R definition maintainer, can I get your eyes on this? 👀 |
@2percentsilk @Chuxel @kmehant If this review is going to take a long time, would it be better to break the PR into base image update and the others? |
@eitsupi Looks good to me! However, I request a review from @Chuxel. @2percentsilk Thanks for tagging me, I apologize for the late response. |
- Change base image from rocker/r-apt to rocker/r-ver - Add vscode R LSP Client extention - Add R packages, languageserver and devtools - Add radian (R console, recommend by vscode-R) - Add the necessary apt packages - Remove libzip-dev, not in use - Add vscode-R recommended settings
LGTM! The new extension is low volume which gave me pause, but I see its maintained by the same maintainers as the existing extension. So from that perspective it's probably ok. Made one fix to move the remoteUser back to vscode given this is what the dockerfile does. |
@eitsupi @kmehant Actually, one thing I just noticed - the At the moment I've removed the comment since I'm not sure if there's higher level tags like "4" and the lower level versions are going to be a bit of a maintenance issue. |
@Chuxel Thank you for merging and the comment fix. There is no higher level tags like "4", and minor versions like "4.0.4" will increase every few months. |
This pull request updates R to latest version and add
vscode-R
recommended settings.rocker/r-apt:bionic
(R 3.6.3) torocker/r-ver
, which provide specific version R (4.0.0 ~ 4.0.4) based on Ubuntu LTS.libzip-dev
. (libzip-dev
was needed for R Tools Add R devcontainer for statistical computing #60, which is not included by Update rust, bazel, perl, azure-cli, R definitions to use common scripts #473 ).libxt-dev
, for to plot without warning.R LSP Client
andR Language Server
.libcurl4-openssl-dev
,libssl-dev
,libxml2-dev
, for to installR Language Server
.devtools
libgit2-dev
, for to installdevtools
radian
.python3-pip
, for to installradian
.