Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository policy #436

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Repository policy #436

merged 4 commits into from
Aug 23, 2021

Conversation

xuzhang3
Copy link
Collaborator

@xuzhang3 xuzhang3 commented Aug 19, 2021

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • [] Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

New resource :
azuredevops_repository_policy_case_enforcement
azuredevops_repository_policy_reserved_names
azuredevops_repository_policy_max_path_length
azuredevops_repository_policy_max_file_size
azuredevops_repository_policy_check_credentials

Updated resource:
azuredevops_repository_policy_author_email_pattern
azuredevops_repository_policy_file_path_pattern

AccTest

=== RUN   TestAccRepositoryPolicyAuthorEmailPatterns
=== RUN   TestAccRepositoryPolicyAuthorEmailPatterns/RepositoryPolicies
=== RUN   TestAccRepositoryPolicyAuthorEmailPatterns/RepositoryPolicies/basic
=== RUN   TestAccRepositoryPolicyAuthorEmailPatterns/RepositoryPolicies/update
=== PAUSE TestAccRepositoryPolicyAuthorEmailPatterns/RepositoryPolicies/update
=== CONT  TestAccRepositoryPolicyAuthorEmailPatterns/RepositoryPolicies/update
=== RUN   TestAccRepositoryPolicyAuthorEmailPatterns/ProjectPolicies
=== RUN   TestAccRepositoryPolicyAuthorEmailPatterns/ProjectPolicies/update
=== PAUSE TestAccRepositoryPolicyAuthorEmailPatterns/ProjectPolicies/update
=== RUN   TestAccRepositoryPolicyAuthorEmailPatterns/ProjectPolicies/basic
=== CONT  TestAccRepositoryPolicyAuthorEmailPatterns/ProjectPolicies/update
--- PASS: TestAccRepositoryPolicyAuthorEmailPatterns (286.50s)
    --- PASS: TestAccRepositoryPolicyAuthorEmailPatterns/RepositoryPolicies (86.50s)
        --- PASS: TestAccRepositoryPolicyAuthorEmailPatterns/RepositoryPolicies/basic (86.50s)
        --- PASS: TestAccRepositoryPolicyAuthorEmailPatterns/RepositoryPolicies/update (81.03s)
    --- PASS: TestAccRepositoryPolicyAuthorEmailPatterns/ProjectPolicies (38.56s)
        --- PASS: TestAccRepositoryPolicyAuthorEmailPatterns/ProjectPolicies/basic (38.56s)
        --- PASS: TestAccRepositoryPolicyAuthorEmailPatterns/ProjectPolicies/update (80.42s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        287.535s


=== RUN   TestAccPolicyCaseEnforcement
=== RUN   TestAccPolicyCaseEnforcement/ProjectPolicies
=== RUN   TestAccPolicyCaseEnforcement/ProjectPolicies/basic
=== RUN   TestAccPolicyCaseEnforcement/ProjectPolicies/update
=== PAUSE TestAccPolicyCaseEnforcement/ProjectPolicies/update
=== CONT  TestAccPolicyCaseEnforcement/ProjectPolicies/update
=== RUN   TestAccPolicyCaseEnforcement/RepositoryPolicies
=== RUN   TestAccPolicyCaseEnforcement/RepositoryPolicies/basic
=== RUN   TestAccPolicyCaseEnforcement/RepositoryPolicies/update
=== PAUSE TestAccPolicyCaseEnforcement/RepositoryPolicies/update
=== CONT  TestAccPolicyCaseEnforcement/RepositoryPolicies/update
--- PASS: TestAccPolicyCaseEnforcement (217.02s)
    --- PASS: TestAccPolicyCaseEnforcement/ProjectPolicies (71.34s)
        --- PASS: TestAccPolicyCaseEnforcement/ProjectPolicies/basic (71.34s)
        --- PASS: TestAccPolicyCaseEnforcement/ProjectPolicies/update (39.86s)
    --- PASS: TestAccPolicyCaseEnforcement/RepositoryPolicies (65.71s)
        --- PASS: TestAccPolicyCaseEnforcement/RepositoryPolicies/basic (65.71s)
        --- PASS: TestAccPolicyCaseEnforcement/RepositoryPolicies/update (40.10s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        217.912s


=== RUN   TestAccRepositoryPolicyFilePathPatterns
=== RUN   TestAccRepositoryPolicyFilePathPatterns/RepositoryPolicies
=== RUN   TestAccRepositoryPolicyFilePathPatterns/RepositoryPolicies/basic
=== PAUSE TestAccRepositoryPolicyFilePathPatterns/RepositoryPolicies/basic
=== RUN   TestAccRepositoryPolicyFilePathPatterns/RepositoryPolicies/update
=== PAUSE TestAccRepositoryPolicyFilePathPatterns/RepositoryPolicies/update
=== CONT  TestAccRepositoryPolicyFilePathPatterns/RepositoryPolicies/basic
=== CONT  TestAccRepositoryPolicyFilePathPatterns/RepositoryPolicies/update
=== RUN   TestAccRepositoryPolicyFilePathPatterns/ProjectPolicies
=== RUN   TestAccRepositoryPolicyFilePathPatterns/ProjectPolicies/basic
=== PAUSE TestAccRepositoryPolicyFilePathPatterns/ProjectPolicies/basic
=== RUN   TestAccRepositoryPolicyFilePathPatterns/ProjectPolicies/update
=== PAUSE TestAccRepositoryPolicyFilePathPatterns/ProjectPolicies/update
=== CONT  TestAccRepositoryPolicyFilePathPatterns/ProjectPolicies/basic
=== CONT  TestAccRepositoryPolicyFilePathPatterns/ProjectPolicies/update
--- PASS: TestAccRepositoryPolicyFilePathPatterns (140.52s)
    --- PASS: TestAccRepositoryPolicyFilePathPatterns/RepositoryPolicies (0.00s)
        --- PASS: TestAccRepositoryPolicyFilePathPatterns/RepositoryPolicies/update (48.74s)
        --- PASS: TestAccRepositoryPolicyFilePathPatterns/RepositoryPolicies/basic (76.28s)
    --- PASS: TestAccRepositoryPolicyFilePathPatterns/ProjectPolicies (0.00s)
        --- PASS: TestAccRepositoryPolicyFilePathPatterns/ProjectPolicies/update (58.02s)
        --- PASS: TestAccRepositoryPolicyFilePathPatterns/ProjectPolicies/basic (64.25s)
=== RUN   TestAccRepositoryPolicyFilePathPatternsProjectPolicyBasic
=== PAUSE TestAccRepositoryPolicyFilePathPatternsProjectPolicyBasic
=== CONT  TestAccRepositoryPolicyFilePathPatternsProjectPolicyBasic
--- PASS: TestAccRepositoryPolicyFilePathPatternsProjectPolicyBasic (35.94s)

=== RUN   TestAccPolicyReservedNames
=== RUN   TestAccPolicyReservedNames/RepositoryPolicies
=== RUN   TestAccPolicyReservedNames/RepositoryPolicies/basic
=== RUN   TestAccPolicyReservedNames/RepositoryPolicies/update
=== PAUSE TestAccPolicyReservedNames/RepositoryPolicies/update
=== CONT  TestAccPolicyReservedNames/RepositoryPolicies/update
=== RUN   TestAccPolicyReservedNames/ProjectPolicies
=== RUN   TestAccPolicyReservedNames/ProjectPolicies/basic
=== RUN   TestAccPolicyReservedNames/ProjectPolicies/update
=== PAUSE TestAccPolicyReservedNames/ProjectPolicies/update
=== CONT  TestAccPolicyReservedNames/ProjectPolicies/update
--- PASS: TestAccPolicyReservedNames (159.24s)
    --- PASS: TestAccPolicyReservedNames/RepositoryPolicies (38.03s)
        --- PASS: TestAccPolicyReservedNames/RepositoryPolicies/basic (38.03s)
        --- PASS: TestAccPolicyReservedNames/RepositoryPolicies/update (38.80s)
    --- PASS: TestAccPolicyReservedNames/ProjectPolicies (44.71s)
        --- PASS: TestAccPolicyReservedNames/ProjectPolicies/basic (44.71s)
        --- PASS: TestAccPolicyReservedNames/ProjectPolicies/update (37.70s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        160.047s

=== RUN   TestAccPolicyFileSize
=== RUN   TestAccPolicyFileSize/RepositoryPolicies
=== RUN   TestAccPolicyFileSize/RepositoryPolicies/basic
=== RUN   TestAccPolicyFileSize/RepositoryPolicies/update
=== PAUSE TestAccPolicyFileSize/RepositoryPolicies/update
=== CONT  TestAccPolicyFileSize/RepositoryPolicies/update
=== RUN   TestAccPolicyFileSize/ProjectPolicies
=== RUN   TestAccPolicyFileSize/ProjectPolicies/basic
=== RUN   TestAccPolicyFileSize/ProjectPolicies/update
=== PAUSE TestAccPolicyFileSize/ProjectPolicies/update
=== CONT  TestAccPolicyFileSize/ProjectPolicies/update
--- PASS: TestAccPolicyFileSize (242.42s)
    --- PASS: TestAccPolicyFileSize/RepositoryPolicies (36.92s)
        --- PASS: TestAccPolicyFileSize/RepositoryPolicies/basic (36.92s)
        --- PASS: TestAccPolicyFileSize/RepositoryPolicies/update (69.48s)
    --- PASS: TestAccPolicyFileSize/ProjectPolicies (66.57s)
        --- PASS: TestAccPolicyFileSize/ProjectPolicies/basic (66.57s)
        --- PASS: TestAccPolicyFileSize/ProjectPolicies/update (69.46s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        243.370s

=== RUN   TestAccPolicyPathLength
=== RUN   TestAccPolicyPathLength/RepositoryPolicies
=== RUN   TestAccPolicyPathLength/RepositoryPolicies/basic
=== RUN   TestAccPolicyPathLength/RepositoryPolicies/update
=== PAUSE TestAccPolicyPathLength/RepositoryPolicies/update
=== CONT  TestAccPolicyPathLength/RepositoryPolicies/update
=== RUN   TestAccPolicyPathLength/ProjectPolicies
=== RUN   TestAccPolicyPathLength/ProjectPolicies/basic
=== RUN   TestAccPolicyPathLength/ProjectPolicies/update
=== PAUSE TestAccPolicyPathLength/ProjectPolicies/update
=== CONT  TestAccPolicyPathLength/ProjectPolicies/update
--- PASS: TestAccPolicyPathLength (182.60s)
    --- PASS: TestAccPolicyPathLength/RepositoryPolicies (37.82s)
        --- PASS: TestAccPolicyPathLength/RepositoryPolicies/basic (37.81s)
        --- PASS: TestAccPolicyPathLength/RepositoryPolicies/update (38.12s)
    --- PASS: TestAccPolicyPathLength/ProjectPolicies (36.54s)
        --- PASS: TestAccPolicyPathLength/ProjectPolicies/basic (36.54s)
        --- PASS: TestAccPolicyPathLength/ProjectPolicies/update (70.13s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        183.425s


Issue Number: #113

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes

  • No
    Configuration has changed:
    azuredevops_repository_policy_author_email_pattern
    azuredevops_repository_policy_file_path_pattern

    1. setting and scope has been removed.
    2. scope is replaced with repository_ids

old config:

# repository policy
resource "azuredevops_repository_policy_author_email_pattern" "p" {
  project_id = azuredevops_project.p.id

  enabled  = true
  blocking = true

  settings {
    author_email_patterns = ["user1@test.com", "user2@test.com"]
    scope {
      repository_id = azuredevops_git_repository.r.id
    }
  }
}

# Set project level repository policy
resource "azuredevops_repository_policy_author_email_pattern" "p" {
  project_id = azuredevops_project.p.id

  enabled  = true
  blocking = true

  settings {
    author_email_patterns = ["user1@test.com", "user2@test.com"]
  }
}

new config:

# repository policy
resource "azuredevops_repository_policy_author_email_pattern" "p" {
  project_id = azuredevops_project.p.id

  enabled  = true
  blocking = true
  author_email_patterns = ["user1@test.com", "user2@test.com"]
  repository_ids = [azuredevops_git_repository.r.id]
}

# Set project level repository policy
resource "azuredevops_repository_policy_author_email_pattern" "p" {
  project_id = azuredevops_project.p.id

  enabled  = true
  blocking = true
  author_email_patterns = ["user1@test.com", "user2@test.com"]
}

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@xuzhang3 xuzhang3 merged commit 73a5975 into microsoft:master Aug 23, 2021
@xuzhang3 xuzhang3 deleted the f/repo_policy branch March 8, 2022 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant