Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net ITextToImageService not following other service modalities standards #5657

Open
RogerBarreto opened this issue Mar 26, 2024 · 2 comments · May be fixed by #8068
Open

.Net ITextToImageService not following other service modalities standards #5657

RogerBarreto opened this issue Mar 26, 2024 · 2 comments · May be fixed by #8068
Assignees
Labels
Ignite .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@RogerBarreto
Copy link
Member

Net ITextToImageService doesn't follow other service modalities standards

Current

public interface ITextToImageService : IAIService
{
    public Task<string> GenerateImageAsync(
        string description,
        int width,
        int height,
        Kernel? kernel = null,
        CancellationToken cancellationToken = default);
}

Expected

public interface ITextToImageService : IAiService 
{
     public Task<IReadOnlyList<ImageContent>> GetImageContentsAsync(
         TextContent input,
         PromptExecutionSettings? executionSettings = null,
         Kernel? kernel = null,
         CancellationToken cancellationToken = default)
}
@RogerBarreto RogerBarreto self-assigned this Mar 26, 2024
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code triage labels Mar 26, 2024
@RogerBarreto RogerBarreto changed the title .Net ITextToImageService Should other services and content standards .Net ITextToImageService knot following other service modalities standards Mar 26, 2024
@RogerBarreto RogerBarreto changed the title .Net ITextToImageService knot following other service modalities standards .Net ITextToImageService not following other service modalities standards Mar 26, 2024
@markwallace-microsoft markwallace-microsoft added sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) and removed triage labels Mar 26, 2024
Copy link

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale Issue is stale because it has been open for 90 days with no activity label Jun 25, 2024
Copy link

github-actions bot commented Jul 9, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ignite .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
None yet
2 participants