From de0c4f231ff7a3606f863537936e83667ab66ab2 Mon Sep 17 00:00:00 2001
From: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Date: Tue, 24 Sep 2024 08:00:57 +0100
Subject: [PATCH] Fix warnings

---
 .../AzureOpenAITextToImageServiceTests.cs      |  4 ++--
 .../AzureOpenAIPromptExecutionSettingsTests.cs |  5 +++--
 .../CompatibilitySuppressions.xml              | 18 ++++++++++++++++++
 .../CompatibilitySuppressions.xml              | 18 ++++++++++++++++++
 .../AzureOpenAI/AzureOpenAITextToImageTests.cs |  4 +++-
 .../OpenAI/OpenAITextToImageTests.cs           |  2 ++
 6 files changed, 46 insertions(+), 5 deletions(-)
 create mode 100644 dotnet/src/Connectors/Connectors.AzureOpenAI/CompatibilitySuppressions.xml
 create mode 100644 dotnet/src/Connectors/Connectors.OpenAI/CompatibilitySuppressions.xml

diff --git a/dotnet/src/Connectors/Connectors.AzureOpenAI.UnitTests/Services/AzureOpenAITextToImageServiceTests.cs b/dotnet/src/Connectors/Connectors.AzureOpenAI.UnitTests/Services/AzureOpenAITextToImageServiceTests.cs
index 215c6bacd10e..c79575e80527 100644
--- a/dotnet/src/Connectors/Connectors.AzureOpenAI.UnitTests/Services/AzureOpenAITextToImageServiceTests.cs
+++ b/dotnet/src/Connectors/Connectors.AzureOpenAI.UnitTests/Services/AzureOpenAITextToImageServiceTests.cs
@@ -17,6 +17,8 @@
 using Moq;
 using OpenAI.Images;
 
+#pragma warning disable CS0618 // Type or member is obsolete
+
 namespace SemanticKernel.Connectors.AzureOpenAI.UnitTests.Services;
 
 /// <summary>
@@ -75,9 +77,7 @@ public async Task GenerateImageWorksCorrectlyAsync(int width, int height, string
         var sut = new AzureOpenAITextToImageService("deployment", "https://api-host", "api-key", modelId, this._httpClient, loggerFactory: this._mockLoggerFactory.Object);
 
         // Act 
-#pragma warning disable CS0618 // Type or member is obsolete
         var result = await sut.GenerateImageAsync("description", width, height);
-#pragma warning restore CS0618 // Type or member is obsolete
 
         // Assert
         Assert.Equal("https://image-url/", result);
diff --git a/dotnet/src/Connectors/Connectors.AzureOpenAI.UnitTests/Settings/AzureOpenAIPromptExecutionSettingsTests.cs b/dotnet/src/Connectors/Connectors.AzureOpenAI.UnitTests/Settings/AzureOpenAIPromptExecutionSettingsTests.cs
index 427815fc44cb..d8ff5b1e0d79 100644
--- a/dotnet/src/Connectors/Connectors.AzureOpenAI.UnitTests/Settings/AzureOpenAIPromptExecutionSettingsTests.cs
+++ b/dotnet/src/Connectors/Connectors.AzureOpenAI.UnitTests/Settings/AzureOpenAIPromptExecutionSettingsTests.cs
@@ -7,6 +7,8 @@
 using Microsoft.SemanticKernel.Connectors.AzureOpenAI;
 using Microsoft.SemanticKernel.Connectors.OpenAI;
 
+#pragma warning disable CS0618 // Type or member is obsolete
+
 namespace SemanticKernel.Connectors.AzureOpenAI.UnitTests.Settings;
 
 /// <summary>
@@ -242,9 +244,8 @@ public void FromExecutionSettingsWithDataDoesNotIncludeEmptyStopSequences()
         var executionSettings = new AzureOpenAIPromptExecutionSettings { StopSequences = [] };
 
         // Act
-#pragma warning disable CS0618 // AzureOpenAIChatCompletionWithData is deprecated in favor of OpenAIPromptExecutionSettings.AzureChatExtensionsOptions
         var executionSettingsWithData = AzureOpenAIPromptExecutionSettings.FromExecutionSettingsWithData(executionSettings);
-#pragma warning restore CS0618
+
         // Assert
         Assert.Null(executionSettingsWithData.StopSequences);
     }
diff --git a/dotnet/src/Connectors/Connectors.AzureOpenAI/CompatibilitySuppressions.xml b/dotnet/src/Connectors/Connectors.AzureOpenAI/CompatibilitySuppressions.xml
new file mode 100644
index 000000000000..86629bb200cf
--- /dev/null
+++ b/dotnet/src/Connectors/Connectors.AzureOpenAI/CompatibilitySuppressions.xml
@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
+<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
+  <Suppression>
+    <DiagnosticId>CP0002</DiagnosticId>
+    <Target>M:Microsoft.SemanticKernel.Connectors.AzureOpenAI.AzureOpenAITextToImageService.GenerateImageAsync(System.String,System.Int32,System.Int32,Microsoft.SemanticKernel.Kernel,System.Threading.CancellationToken)</Target>
+    <Left>lib/net8.0/Microsoft.SemanticKernel.Connectors.AzureOpenAI.dll</Left>
+    <Right>lib/net8.0/Microsoft.SemanticKernel.Connectors.AzureOpenAI.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0002</DiagnosticId>
+    <Target>M:Microsoft.SemanticKernel.Connectors.AzureOpenAI.AzureOpenAITextToImageService.GenerateImageAsync(System.String,System.Int32,System.Int32,Microsoft.SemanticKernel.Kernel,System.Threading.CancellationToken)</Target>
+    <Left>lib/netstandard2.0/Microsoft.SemanticKernel.Connectors.AzureOpenAI.dll</Left>
+    <Right>lib/netstandard2.0/Microsoft.SemanticKernel.Connectors.AzureOpenAI.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+</Suppressions>
\ No newline at end of file
diff --git a/dotnet/src/Connectors/Connectors.OpenAI/CompatibilitySuppressions.xml b/dotnet/src/Connectors/Connectors.OpenAI/CompatibilitySuppressions.xml
new file mode 100644
index 000000000000..c3b3af979029
--- /dev/null
+++ b/dotnet/src/Connectors/Connectors.OpenAI/CompatibilitySuppressions.xml
@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
+<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
+  <Suppression>
+    <DiagnosticId>CP0002</DiagnosticId>
+    <Target>M:Microsoft.SemanticKernel.Connectors.OpenAI.OpenAITextToImageService.GenerateImageAsync(System.String,System.Int32,System.Int32,Microsoft.SemanticKernel.Kernel,System.Threading.CancellationToken)</Target>
+    <Left>lib/net8.0/Microsoft.SemanticKernel.Connectors.OpenAI.dll</Left>
+    <Right>lib/net8.0/Microsoft.SemanticKernel.Connectors.OpenAI.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0002</DiagnosticId>
+    <Target>M:Microsoft.SemanticKernel.Connectors.OpenAI.OpenAITextToImageService.GenerateImageAsync(System.String,System.Int32,System.Int32,Microsoft.SemanticKernel.Kernel,System.Threading.CancellationToken)</Target>
+    <Left>lib/netstandard2.0/Microsoft.SemanticKernel.Connectors.OpenAI.dll</Left>
+    <Right>lib/netstandard2.0/Microsoft.SemanticKernel.Connectors.OpenAI.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+</Suppressions>
\ No newline at end of file
diff --git a/dotnet/src/IntegrationTests/Connectors/AzureOpenAI/AzureOpenAITextToImageTests.cs b/dotnet/src/IntegrationTests/Connectors/AzureOpenAI/AzureOpenAITextToImageTests.cs
index fb417d990dd1..ac3f6d020c55 100644
--- a/dotnet/src/IntegrationTests/Connectors/AzureOpenAI/AzureOpenAITextToImageTests.cs
+++ b/dotnet/src/IntegrationTests/Connectors/AzureOpenAI/AzureOpenAITextToImageTests.cs
@@ -9,6 +9,8 @@
 using SemanticKernel.IntegrationTests.TestSettings;
 using Xunit;
 
+#pragma warning disable CS0618 // Type or member is obsolete
+
 namespace SemanticKernel.IntegrationTests.Connectors.AzureOpenAI;
 
 public sealed class AzureOpenAITextToImageTests
@@ -67,6 +69,6 @@ public async Task GetImageContentsCanReturnImageUrlAsync()
         Assert.NotNull(result);
         Assert.NotEmpty(result);
         Assert.NotEmpty(result[0].Uri!.ToString());
-        Assert.StartsWith("https://", result[0].Uri);
+        Assert.StartsWith("https://", result[0].Uri!.ToString());
     }
 }
diff --git a/dotnet/src/IntegrationTests/Connectors/OpenAI/OpenAITextToImageTests.cs b/dotnet/src/IntegrationTests/Connectors/OpenAI/OpenAITextToImageTests.cs
index 9a01f2b23db8..1c3f1b66ed69 100644
--- a/dotnet/src/IntegrationTests/Connectors/OpenAI/OpenAITextToImageTests.cs
+++ b/dotnet/src/IntegrationTests/Connectors/OpenAI/OpenAITextToImageTests.cs
@@ -8,6 +8,8 @@
 using SemanticKernel.IntegrationTests.TestSettings;
 using Xunit;
 
+#pragma warning disable CS0618 // Type or member is obsolete
+
 namespace SemanticKernel.IntegrationTests.Connectors.OpenAI;
 public sealed class OpenAITextToImageTests
 {