Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npx @microsoft/sarif-multitool <args> fails on Linux #1963

Closed
rsenden opened this issue Jul 2, 2020 · 1 comment · Fixed by #1986
Closed

npx @microsoft/sarif-multitool <args> fails on Linux #1963

rsenden opened this issue Jul 2, 2020 · 1 comment · Fixed by #1986

Comments

@rsenden
Copy link

rsenden commented Jul 2, 2020

Instructions at https://www.npmjs.com/package/@microsoft/sarif-multitool state the following usage instructions:

npm i -g @microsoft/sarif-multitool
npx @microsoft/sarif-multitool <args>

However on Linux this fails with an error like the following, because the module tries to execute a native executable that doesn't have the executable flag:

/bin/sh: 1: /usr/local/lib/node_modules/@microsoft/sarif-multitool/node_modules/@microsoft/sarif-multitool-linux/Sarif.Multitool: Permission denied

This behavior was observed on Ubuntu for Windows, and on a GitHub-hosted Ubuntu runner.

A simple chmod +x ... fixes this error, however this step is not documented, and preferably the module should take care of this by itself, without requiring users to manually change permissions in some global node modules directory.

@jeffersonking
Copy link
Collaborator

jeffersonking commented Jul 9, 2020

@rsenden Agreed this should not require manual integration.

I have intermittently run into this issue. I have seen cases where the binary unpacks with executable permissions and other cases where it does not. The plan was to take a closer look at the moment we pack them to see if we can get it right up front. Fallback will be a post-install chmod. We will increase the priority of the investigation. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants