Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NativeOrDynamicColor Related Patches When PlatformColor is Available #3990

Closed
NickGerleman opened this issue Jan 30, 2020 · 2 comments · Fixed by #5028
Closed

Remove NativeOrDynamicColor Related Patches When PlatformColor is Available #3990

NickGerleman opened this issue Jan 30, 2020 · 2 comments · Fixed by #5028
Assignees
@NickGerleman
Labels
Code Cleanup Deforking
Milestone
0.63

Comments

@NickGerleman
Copy link
Collaborator

NickGerleman commented Jan 30, 2020 •
edited
Loading

These are replicated for both win32 and windows right now (but might diverge further). These will be superseded by react-native-community/discussions-and-proposals#126.
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jan 30, 2020
@NickGerleman NickGerleman changed the title Upstream NativeOrDynamicColor or Similar Remove NativeOrDynamicColor When PlatformColor is upstreamed Jan 30, 2020
@NickGerleman NickGerleman changed the title Remove NativeOrDynamicColor When PlatformColor is upstreamed Remove NativeOrDynamicColor When PlatformColor is Available Jan 30, 2020
@NickGerleman NickGerleman removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jan 30, 2020
@harinikmsft harinikmsft added this to the 0.63 (M6) milestone Mar 12, 2020
@harinikmsft
Copy link
Contributor

PlatformColor API will be part of RN v0.63. Windows will consume this once it is available and match when shipping corresponding react-native-windows v0.63.

@chrisglein chrisglein removed the vnext label Mar 18, 2020
@NickGerleman NickGerleman self-assigned this Mar 20, 2020
@NickGerleman NickGerleman changed the title Remove NativeOrDynamicColor When PlatformColor is Available Remove NativeOrDynamicColor Related Patches When PlatformColor is Available Mar 20, 2020
@acoates-ms
Copy link
Contributor

Fixed in #5028

@NickGerleman NickGerleman mentioned this issue Jun 12, 2020
Merged
@ghost ghost closed this as completed in #5028 Jun 26, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NickGerleman NickGerleman

Labels
Code Cleanup Deforking
Projects
None yet
Milestone
0.63
Development

Successfully merging a pull request may close this issue.

Integrate of 3/22 Nightly Build NickGerleman/react-native-windows
4 participants
@NickGerleman @harinikmsft @chrisglein @acoates-ms