Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client factory should set the baseUrl for the path parameters #2061

Closed
baywet opened this issue Dec 13, 2022 · 0 comments · Fixed by #2123
Closed

client factory should set the baseUrl for the path parameters #2061

baywet opened this issue Dec 13, 2022 · 0 comments · Fixed by #2123
Assignees
@baywet
Labels
Csharp Pull requests that update .net code fixed generator Issues or improvements relater to generation capabilities. Go Java type:bug A broken experience TypeScript Pull requests that update Javascript code
Milestone
Kiota v1

Comments

@baywet
Copy link
Member

baywet commented Dec 13, 2022 •
edited
Loading

request generator methods (createXXXRequestInformation) don't currently set the base URL. This means the generated request is only usable as long as it's executed via the request adapter making other uses cases (batching, diagnoses, etc...) hard to implement. request.PathParameters["baseUrl"] = requestAdapter.BaseServiceUrl neeeds to be added to the client factory as path parameters are pass along the fluent API. This way the impact to the client size will stay minimal.
@baywet baywet added type:bug A broken experience generator Issues or improvements relater to generation capabilities. Csharp Pull requests that update .net code Go Java TypeScript Pull requests that update Javascript code labels Dec 13, 2022
@baywet baywet added this to the Kiota GA milestone Dec 13, 2022
@baywet baywet self-assigned this Dec 13, 2022
@baywet baywet changed the title request generator should set the base URL on the request client factory should set the baseUrl for the path parameters Dec 13, 2022
@baywet baywet mentioned this issue Jan 6, 2023
Merged
@baywet baywet added the fixed label Jan 6, 2023
This was referenced Jul 23, 2024
Open
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baywet baywet

Labels
Csharp Pull requests that update .net code fixed generator Issues or improvements relater to generation capabilities. Go Java type:bug A broken experience TypeScript Pull requests that update Javascript code
Projects
Kiota
Archived in project
Milestone
Kiota v1
Development

Successfully merging a pull request may close this issue.

feature/set base url microsoft/kiota
1 participant
@baywet