From c671faf1b8b64b6d686922b6d0914863c7c5a530 Mon Sep 17 00:00:00 2001 From: Sofiya Huts Date: Mon, 21 Jan 2019 11:18:27 +0100 Subject: [PATCH 1/2] fix(Popup): Do not stop propagation when pressing Esc on trigger element --- src/components/Popup/Popup.tsx | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/components/Popup/Popup.tsx b/src/components/Popup/Popup.tsx index d855e98be..07631d290 100644 --- a/src/components/Popup/Popup.tsx +++ b/src/components/Popup/Popup.tsx @@ -175,10 +175,7 @@ export default class Popup extends AutoControlledComponent _.invoke(this.triggerDomElement, 'focus')) e.stopPropagation() }, - close: e => { - this.close(e) - e.stopPropagation() - }, + close: e => this.close(e), } public componentDidMount() { From 4f29987800e04a011cfd795fd6affa038d244038 Mon Sep 17 00:00:00 2001 From: Sofiya Huts Date: Mon, 21 Jan 2019 11:28:01 +0100 Subject: [PATCH 2/2] Update chnagelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 78a0d75f7..bdd96db6b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm - Fix focus outline visible only during keyboard navigation in `ListItem` @layershifter ([#727](https://github.com/stardust-ui/react/pull/727)) - Pass `jest --detectLeaks` tests @miroslavstastny ([#718](https://github.com/stardust-ui/react/pull/718)) - Fix Avatar's size example @mnajdova ([#745](https://github.com/stardust-ui/react/pull/745)) +- Fix `Popup` - do not stop event propagation when pressing Esc on trigger element @sophieH29 ([#750](https://github.com/stardust-ui/react/pull/750)) ### Features - Rename `Slot` component to `Box` and export it @Bugaa92 ([#713](https://github.com/stardust-ui/react/pull/713))