This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Popup: refactor to avoid strange condition #1630

Open

layershifter opened this issue Jul 12, 2019 · 0 comments

Labels

vsts

Member

layershifter commented Jul 12, 2019

Bug Report

const popupContent = Popup.Content.create(content || {}, {

If we will pass false or null to this slot we will render nothing and it will break Popper and Ref components that expects children. I want to consider refactoring of this place more deeply.

#1513 (comment)

layershifter mentioned this issue

fix(factories): handle ReactElement as primitive #1513

Merged

pkumarie2011 added the vsts label

assuncaocharles mentioned this issue

fix(Popup): Avoid weird condition on popup microsoft/fluentui#13064

Closed

2 tasks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.